Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: uninstall eslint-plugin-jest and ts-jest as dev dependencies #812

Merged
merged 1 commit into from
Sep 7, 2023
Merged

feat: uninstall eslint-plugin-jest and ts-jest as dev dependencies #812

merged 1 commit into from
Sep 7, 2023

Conversation

vasanth9
Copy link
Contributor

@vasanth9 vasanth9 commented Sep 7, 2023

PR Checklist

Overview

updated devDependenciesToRemove array with eslint-plugin-jest and ts-jest

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #812 (a634c47) into main (b96c7b3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #812   +/-   ##
=======================================
  Coverage   91.60%   91.61%           
=======================================
  Files          84       84           
  Lines        4158     4160    +2     
  Branches      248      248           
=======================================
+ Hits         3809     3811    +2     
  Misses        349      349
Flag Coverage Δ
create 72.03% <100.00%> (+0.01%) ⬆️
initialize 34.06% <100.00%> (+0.03%) ⬆️
migrate 73.34% <100.00%> (+0.01%) ⬆️
unit 47.69% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/steps/writing/creation/writePackageJson.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vasanth9 vasanth9 changed the title added eslint-plugin-jest and ts-jest to array feat: uninstall eslint-plugin-jest and ts-jest as dev dependencies Sep 7, 2023
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Sep 7, 2023
View reviewed changes
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! 💯

The migration script failure is unrelated (#796). We can ignore it.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 1a2b55c into JoshuaKGoldberg:main Sep 7, 2023
15 of 17 checks passed
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @vasanth9 for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this pull request Sep 7, 2023
Merged
@allcontributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @vasanth9! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

🎉 This is included in version v1.29.35 🎉

The release is available on:

Cheers! 📦🚀

JoshuaKGoldberg pushed a commit that referenced this pull request Sep 7, 2023
@allcontributors
docs: add vasanth9 as a contributor for code (#813)
d8aa575 
Adds @vasanth9 as a contributor for code.

This was requested by JoshuaKGoldberg [in this
comment](#812 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@vasanth9 vasanth9 deleted the feature/update_array-devDependenciesToRemove branch September 7, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Also uninstall eslint-plugin-jest and ts-jest as dev dependencies
2 participants
@vasanth9 @JoshuaKGoldberg