Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated default emojis list for 2023 #138

Merged
merged 1 commit into from
May 28, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

As before, I've tried to keep the list of emojis to ones that are purely fun, positive vibes. This list has a bit more variety in non-face emojis so I've removed the double-probability duplicates.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Merging #138 (8bd40fa) into main (fe1ef21) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #138      +/-   ##
========================================
- Coverage   2.94%   2.93%   -0.01%     
========================================
  Files         13      13              
  Lines        849     851       +2     
========================================
  Hits          25      25              
- Misses       824     826       +2     
Impacted Files Coverage Δ
src/emojis.ts 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@cgradeff cgradeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!! excited for the new emojis💃

@JoshuaKGoldberg JoshuaKGoldberg merged commit c0d096a into main May 28, 2023
11 of 13 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the default-emojis-2023 branch May 28, 2023 04:31
@JoshuaKGoldberg
Copy link
Owner Author

Whoops, meant to note this fixed #138.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants