Skip to content

Commit

Permalink
fix: correct suggestion status (#299)
Browse files Browse the repository at this point in the history
<!-- πŸ‘‹ Hi, thanks for sending a PR to eslint-plugin-package-json! πŸ’–.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

-   [x] Addresses an existing open issue: fixes #255
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

<!-- Description of what is changed and how the code change does that.
-->
  • Loading branch information
hyoban committed Apr 11, 2024
1 parent bc1e902 commit 146e25d
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 8 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,10 @@ The default settings don't conflict, and Prettier plugins can quickly fix up ord
| [sort-collections](docs/rules/sort-collections.md) | Dependencies, scripts, and configuration values must be declared in alphabetical order. | βœ… | πŸ”§ | |
| [unique-dependencies](docs/rules/unique-dependencies.md) | Enforce that if repository directory is specified, it matches the path to the package.json file | βœ… | | πŸ’‘ |
| [valid-local-dependency](docs/rules/valid-local-dependency.md) | Checks existence of local dependencies in the package.json | βœ… | | |
| [valid-name](docs/rules/valid-name.md) | Enforce that package names are valid npm package names | βœ… | | πŸ’‘ |
| [valid-name](docs/rules/valid-name.md) | Enforce that package names are valid npm package names | βœ… | | |
| [valid-package-def](docs/rules/valid-package-def.md) | Enforce that package.json has all properties required by the npm spec | βœ… | | |
| [valid-repository-directory](docs/rules/valid-repository-directory.md) | Enforce that if repository directory is specified, it matches the path to the package.json file | βœ… | | πŸ’‘ |
| [valid-version](docs/rules/valid-version.md) | Enforce that package versions are valid semver specifiers | βœ… | | πŸ’‘ |
| [valid-version](docs/rules/valid-version.md) | Enforce that package versions are valid semver specifiers | βœ… | | |

<!-- end auto-generated rules list -->
<!-- prettier-ignore-end -->
Expand Down
2 changes: 0 additions & 2 deletions docs/rules/valid-name.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

πŸ’Ό This rule is enabled in the βœ… `recommended` config.

πŸ’‘ This rule is manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).

<!-- end auto-generated rule header -->

This rule applies two validations to the `"name"` property:
Expand Down
2 changes: 0 additions & 2 deletions docs/rules/valid-version.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

πŸ’Ό This rule is enabled in the βœ… `recommended` config.

πŸ’‘ This rule is manually fixable by [editor suggestions](https://eslint.org/docs/latest/use/core-concepts#rule-suggestions).

<!-- end auto-generated rule header -->

This rule applies two validations to the `"name"` property:
Expand Down
1 change: 0 additions & 1 deletion src/rules/valid-name.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ export const rule = createRule({
"Enforce that package names are valid npm package names",
recommended: true,
},
hasSuggestions: true,
messages: {
invalid: "Invalid npm package name: {{ complaints }}.",
type: '"name" should be a string.',
Expand Down
1 change: 0 additions & 1 deletion src/rules/valid-version.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ export const rule = createRule({
"Enforce that package versions are valid semver specifiers",
recommended: true,
},
hasSuggestions: true,
messages: {
invalid: "Version is not a valid semver specifier.",
type: '"version" should be a string.',
Expand Down

0 comments on commit 146e25d

Please sign in to comment.