Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Support flat config #91

Closed
3 tasks done
KristjanESPERANTO opened this issue Jan 5, 2024 · 5 comments · Fixed by #161
Closed
3 tasks done

🚀 Feature: Support flat config #91

KristjanESPERANTO opened this issue Jan 5, 2024 · 5 comments · Fixed by #161
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@KristjanESPERANTO
Copy link
Contributor

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Configuration using eslintrc will be deprecated soon. Unfortunately I can't manage to get this plugin into a flat configuration. Is this already possible?

Additional Info

No response
@KristjanESPERANTO KristjanESPERANTO added the type: feature New enhancement or request label Jan 5, 2024
@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! label Jan 5, 2024
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @KristjanESPERANTO for ideas.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this issue Jan 20, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @KristjanESPERANTO! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

JoshuaKGoldberg added a commit that referenced this issue Jan 20, 2024
@allcontributors @JoshuaKGoldberg
docs: add kristjanesperanto as a contributor for ideas (#104)
3e25404 
Adds @KristjanESPERANTO as a contributor for ideas.

This was requested by JoshuaKGoldberg [in this
comment](#91 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 20, 2024
Merged
3 tasks
This was referenced Feb 17, 2024
Closed
Closed
@JoshuaKGoldberg
Copy link
Owner

ESLint's Plugin Migration Guide has more info. For this plugin in particular we'd want to:

  • Expose the meta and configs properties
  • Document how to use them with flat config in the README.md

@hyoban hyoban mentioned this issue Feb 20, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Mar 24, 2024
@hyoban @JoshuaKGoldberg
feat: support flat config (#161)
bf31a6c 
<!-- 👋 Hi, thanks for sending a PR to eslint-plugin-package-json! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

-   [x] Addresses an existing open issue: fixes #91
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

<!-- Description of what is changed and how the code change does that.
-->

Some code are not very good, looking forward to your suggestions

---------

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@github-actions GitHub Actions
Copy link

🎉 This is included in version v0.11.0 🎉

The release is available on:

Cheers! 📦🚀

@KristjanESPERANTO
Copy link
Contributor Author

Great! Thank you very much! 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support flat config
2 participants
@JoshuaKGoldberg @KristjanESPERANTO