fix: recommended config #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
approved these changes
Jan 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
==========================================
+ Coverage 94.52% 98.58% +4.06%
==========================================
Files 7 7
Lines 420 424 +4
Branches 28 30 +2
==========================================
+ Hits 397 418 +21
+ Misses 23 6 -17 ☔ View full report in Codecov by Sentry. |
|
@all-contributors please add @ota-meshi for code.
|
|
We had trouble processing your request. Please try again later. |
3 tasks
JoshuaKGoldberg
added a commit
that referenced
this pull request
Jan 20, 2024
## PR Checklist - [x] Addresses an existing open issue: fixes #110 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Regenerates the table following #103. ```shell pnpm run update:eslint-docs ```
|
@all-contributors please add @ota-meshi for code. 😠 |
|
I've put up a pull request to add @ota-meshi! 🎉 |
JoshuaKGoldberg
pushed a commit
that referenced
this pull request
Jan 20, 2024
Adds @ota-meshi as a contributor for code. This was requested by JoshuaKGoldberg [in this comment](#103 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
This PR fixes
"plugin:package-json/recommended"to work and adds a test case to check the fix.