Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added valid-repository-directory rule #123

Merged
merged 4 commits into from
Jan 20, 2024

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Jan 20, 2024

PR Checklist

Overview

Equivalent to json-files/ensure-repository-directory. Renamed to valid-* to match the precedent of the existing rules valid-package-def and valid-package-dependency.

Re-uses the findJSONLiteralWithValue utility and renames it to the more appropriate findPropertyWithKeyValue

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (928c5b4) 98.89% compared to head (fcd5b96) 98.52%.

Files Patch % Lines
src/rules/valid-repository-directory.ts 95.38% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   98.89%   98.52%   -0.37%     
==========================================
  Files           8       10       +2     
  Lines         542      610      +68     
  Branches       47       49       +2     
==========================================
+ Hits          536      601      +65     
- Misses          6        9       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg
Copy link
Owner Author

I don't know why the test coverage reports aren't counting the line as hit. Will merge with not quite 100% coverage.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 84035c3 into main Jan 20, 2024
12 of 14 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the valid-repository-directory branch January 20, 2024 05:40
Copy link

🎉 This is included in version v0.7.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring in a ensure-repository-directory rule equivalent
1 participant