Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: detect package.json in Windows #30

Merged
merged 1 commit into from
Sep 15, 2023
Merged

fix: detect package.json in Windows #30

merged 1 commit into from
Sep 15, 2023

Conversation

JoshuaKGoldberg
Copy link
Owner

Fixes #13

@Zamiell
Copy link
Contributor

Zamiell commented Sep 13, 2023

wouldn't it be simpler to use path.sep?

@JoshuaKGoldberg
Copy link
Owner Author

Probably. But the regexp avoids a dependency on path. Which might long-term be more portable.

@Zamiell
Copy link
Contributor

Zamiell commented Sep 13, 2023

historically I've not thought of node builtins as "dependencies", but fair enough =p

@JoshuaKGoldberg JoshuaKGoldberg merged commit fdb73fb into master Sep 15, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the package-json-windows-detection branch September 15, 2023 16:40
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Feb 1, 2024
Closed
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg restored the package-json-windows-detection branch February 1, 2024 01:10
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Feb 1, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this pull request Feb 1, 2024
@JoshuaKGoldberg
fix: support Windows paths, again (#144)
27243fa 
## PR Checklist

-   [x] Addresses an existing open issue: fixes #142
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Re-applies #30 to the `main` branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does not detect package.json in Windows environment
2 participants
@JoshuaKGoldberg @Zamiell