chore: switch valid-local-dependency tests to not rely on file system casing #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for doing this! |
kendallgassner
approved these changes
Nov 6, 2023
JoshuaKGoldberg
deleted the
valid-local-dependency-tests-invalid-paths
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60.
The problem was the
invalidcases weren't giving errors when the resolved path differed from file system casing. Requested paths like.../Valid-local-dependencywere passing when the file case on system was.../valid-local-dependency. I played a bit with adding explicit logic to check for case sensitivity but:...so this instead switches the tests to use paths that differ in more than just casing.