Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃洜 Tooling: Add a bot that suggests auto-formatting #139

Open
3 tasks done
JoshuaKGoldberg opened this issue Dec 21, 2022 · 8 comments
Open
3 tasks done

馃洜 Tooling: Add a bot that suggests auto-formatting #139

JoshuaKGoldberg opened this issue Dec 21, 2022 · 8 comments
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Dec 21, 2022

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Sometimes folks make edits in an environment without Git hooks, such as the web editor (or they use git commit --no-verify). Their commits and PRs will have big red 鉂宻 complaining about formatting issues. Asking them to run Prettier might be too difficult; asking them to make manual edits might be too tedious.

Let's add a bot that offers to apply Prettier fixing for them. It should explain what the formatting needs are and have something like 'react with 馃憤' and/or 'reply with yes' to trigger.

Edit: maybe not that last bit around having them react/reply? Maybe that can be an addon later? Honestly I haven't put too much thought into the UX of it. No, I really want this to be an opt-in thing. Folks who don't understand Git/GitHub well sometimes have a hard time updating their local branch from the upstream/origin.

Additional Info

This will be particularly useful for projects such as https://github.com/OpenContributionsProject/opensourcecontributionssite that are intended to have non-programmer folks participate.

@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! labels Dec 21, 2022
@takanome-dev
Copy link
Contributor

Oh, that's an interesting idea. Is there a bot that does something similar?
I'll try tinkering about this 馃榿

@JoshuaKGoldberg
Copy link
Owner Author

Hooray!

Is there a bot that does something similar?

I vaguely remember poking around online and not finding much. There are bots that do it automatically, but I don't remember finding any that do it on command.

If such a thing doesn't exist, I'd want it to be a separate bot/action/thing (rather than a bunch of scripts checked into this repo). That way other folks can use it too, outside of this template!

@takanome-dev
Copy link
Contributor

@JoshuaKGoldberg just started experimenting with a github action at https://github.com/TAKANOME-DEV/prettify-action. Any suggestions is welcomed 馃檹

@nowyDEV
Copy link
Contributor

nowyDEV commented Feb 22, 2023

@takanome-dev I've had a working setup of this feature in another project so decided to make a quick PR #261
Edit: looks like it's not gonna be so easy since we use pnpm 馃樅

@takanome-dev
Copy link
Contributor

takanome-dev commented Feb 22, 2023

@takanome-dev I've had a working setup of this feature in another project so decided to make a quick PR #261 Edit: looks like it's not gonna be so easy since we use pnpm smiley_cat

Woow, pretty cool. Didn't know something like that existed.
We can fork it and make the necessary changes 馃殌

Edit: Ok, don't know why to rewrite it using pnpm 馃槄 Can you elaborate more on that?

@navin-moorthy
Copy link
Contributor

May be this can be useful for this issues?

https://autofix.ci/
https://autofix.ci/setup#typescript

@JoshuaKGoldberg
Copy link
Owner Author

If it can offer to fix things, rather than just do it always, then great!

@JoshuaKGoldberg JoshuaKGoldberg added this to the Long-Desired Features milestone Feb 14, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title 馃洜 Tooling: Add a bot that suggests auto-formatting with Prettier 馃洜 Tooling: Add a bot that suggests auto-formatting Apr 23, 2024
@johnnyreilly
Copy link
Sponsor Collaborator

This is a cool idea. Fact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants