Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: unnecessary files published #200

Closed
3 tasks done
bradzacher opened this issue Apr 12, 2023 · 1 comment · Fixed by #209
Closed
3 tasks done

🐛 Bug: unnecessary files published #200

bradzacher opened this issue Apr 12, 2023 · 1 comment · Fixed by #209
Labels
good first issue Good for newcomers, please hop on! 🙌

Comments

@bradzacher
Copy link

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

The npm package contains the minimal files required to run the code

Actual

https://unpkg.com/browse/console-fail-test@0.1.8/

image

Additional Info

Can either use .npmignore to ignore files, or package.json files: string[] to specify which files to publish.
@JoshuaKGoldberg
Copy link
Owner

AH yes thanks - at some point Soon ™️ I will go through all my repos and standardize their tooling on template-typescript-node-package. Which does use package.json files: string[].

(I've been procrastinating doing that as there are still some niceties (JoshuaKGoldberg/create-typescript-app#23, JoshuaKGoldberg/create-typescript-app#139, JoshuaKGoldberg/create-typescript-app#303, JoshuaKGoldberg/create-typescript-app#312, JoshuaKGoldberg/create-typescript-app#319, JoshuaKGoldberg/create-typescript-app#371) I'd like to get in first, so I don't have to re-apply them to all the repos)

This particular issue should be pretty straightforward to port to console-fail-test / other repos if you'd like to have it fixed in the meantime! Accepting PRs. Thanks for filing!

@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! 🙌 accepting prs labels Apr 12, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Apr 12, 2023
Closed
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue May 22, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Nov 12, 2023
@JoshuaKGoldberg
build: onboard to create-typescript-app (#209)
acfe3df 
## PR Checklist

- [x] Addresses an existing open issue: fixes #43; fixes #200
- [x] That issue was marked as [accepting
prs](https://github.com/JoshuaKGoldberg/console-fail-test/issues?q=is%3Aopen+is%3Aissue+label%3A%22accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/console-fail-test/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Runs
[`create-typescript-app`](http://github.com/JoshuaKGoldberg/create-typescript-app)'s
hydration logic on this repo to bring in all the tooling goodness from
that repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers, please hop on! 🙌
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: onboard to create-typescript-app JoshuaKGoldberg/console-fail-test
2 participants
@JoshuaKGoldberg @bradzacher