Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Feature: Fill in remaining tsutils functions (that don't exist on TypeScript) #3

Closed
3 tasks done
JoshuaKGoldberg opened this issue Feb 6, 2023 · 2 comments 路 Fixed by #46
Closed
3 tasks done
Labels
good first issue Good for newcomers, please hop on! 馃檶 status: accepting prs Please, send a pull request to resolve this! 馃檹 type: feature New enhancement or request 馃殌

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

I'm filing this as a catch-all issue for anybody interested in contributing! 馃憢

tsutils has a lot of functions in it. Many of them are now available as part of this package. But some of them aren't. Welcoming contributions to add functions to this package that exist in tsutils but not yet in ts-api-tools.

The one exception to this is type guards such as isBinaryExpression that now exist on TypeScript itself. tsutils contains a lot of those functions for backwards compatibility with old tsutils+typescript versions - but this package doesn't need to.

Additional Info

Any new file whose contents are essentially a copy & paste of a tsutils file should have the same licensing header as other source files of that nature:

// Code largely based on https://github.com/ajafff/tsutils
// Original license: https://github.com/ajafff/tsutils/blob/26b195358ec36d59f00333115aa3ffd9611ca78b/LICENSE
@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @JoshuaKGoldberg for ideas.

馃 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 馃挋

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @JoshuaKGoldberg! 馃帀

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

JoshuaKGoldberg pushed a commit that referenced this issue Jan 17, 2024
Adds @JoshuaKGoldberg as a contributor for ideas.

This was requested by JoshuaKGoldberg [in this
comment](#3 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers, please hop on! 馃檶 status: accepting prs Please, send a pull request to resolve this! 馃檹 type: feature New enhancement or request 馃殌
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant