Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump ts to v5 #124

Merged
merged 8 commits into from
Mar 20, 2023
Merged

build: bump ts to v5 #124

merged 8 commits into from
Mar 20, 2023

Conversation

RebeccaStevens
Copy link
Collaborator

@RebeccaStevens RebeccaStevens commented Feb 22, 2023

PR Checklist

Overview

To be (update and) merged once v5 full comes out.

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #124 (a51f0e3) into main (c26ab15) will decrease coverage by 0.32%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   21.80%   21.49%   -0.32%     
==========================================
  Files          18       18              
  Lines         431      442      +11     
  Branches      171      177       +6     
==========================================
+ Hits           94       95       +1     
- Misses        315      324       +9     
- Partials       22       23       +1     
Flag Coverage Δ
4.2.4 20.81% <25.00%> (-0.30%) ⬇️
4.3.5 21.04% <25.00%> (-0.31%) ⬇️
4.4.4 21.04% <25.00%> (-0.31%) ⬇️
latest 20.81% <25.00%> (-0.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/comments.ts 0.00% <ø> (ø)
src/nodes/typeGuards/compound.ts 40.90% <ø> (ø)
src/nodes/typeGuards/single.ts 0.00% <ø> (ø)
src/nodes/typeGuards/union.ts 1.80% <0.00%> (-0.14%) ⬇️
src/nodes/utilities.ts 0.00% <ø> (ø)
src/tokens.ts 0.00% <ø> (ø)
src/types/getters.ts 36.36% <ø> (ø)
src/types/typeGuards/compound.ts 14.28% <ø> (ø)
src/types/typeGuards/objects.ts 50.00% <ø> (ø)
src/types/typeGuards/simple.ts 33.33% <ø> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thanks @RebeccaStevens! 🚀

@RebeccaStevens RebeccaStevens requested review from JoshuaKGoldberg and removed request for JoshuaKGoldberg February 25, 2023 07:17
@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Mar 11, 2023
@RebeccaStevens RebeccaStevens changed the title build: bump ts to v5 beta build: bump ts to v5 rc Mar 13, 2023
@RebeccaStevens RebeccaStevens added status: blocked Waiting for something else to be resolved 🙅 and removed status: waiting for author Needs an action taken by the original poster labels Mar 13, 2023
@RebeccaStevens RebeccaStevens removed the status: blocked Waiting for something else to be resolved 🙅 label Mar 17, 2023
@RebeccaStevens RebeccaStevens changed the title build: bump ts to v5 rc build: bump ts to v5 Mar 17, 2023
@RebeccaStevens
Copy link
Collaborator Author

Something seems to be going wrong with ts.createProgram.

@RebeccaStevens
Copy link
Collaborator Author

@JoshuaKGoldberg I got this working by using tsvfs.createVirtualTypeScriptEnvironment instead of tsvfs.createVirtualCompilerHost. Not sure why exactly this change was needed but it works now.

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, it works! 🚀

@RebeccaStevens RebeccaStevens merged commit 6050cfe into main Mar 20, 2023
@RebeccaStevens RebeccaStevens deleted the ts5 branch March 20, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Support TypeScript v5
2 participants