chore: added an assortment of unit tests #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #205 +/- ##
===========================================
+ Coverage 20.78% 46.84% +26.05%
===========================================
Files 20 20
Lines 457 459 +2
Branches 179 179
===========================================
+ Hits 95 215 +120
+ Misses 338 216 -122
- Partials 24 28 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JoshuaKGoldberg
force-pushed
the
assorted-tests
branch
7 times, most recently
from
5553cfd
to
352ba21
Compare
JoshuaKGoldberg
force-pushed
the
assorted-tests
branch
from
352ba21
to
17b65c5
Compare
JoshuaKGoldberg
commented
Apr 27, 2023
| expect(callback).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| if (isTsVersionAtLeast(4, 3)) { |
There was a problem hiding this comment.
This fails in TS 4.2: https://github.com/JoshuaKGoldberg/ts-api-utils/actions/runs/4815452608/jobs/8574152647?pr=205
...which makes me motivated to drop support for TS 4.2. #206
There was a problem hiding this comment.
I'm all for using newer versions
RebeccaStevens
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
I had some time on a road trip today and was motivated to backfill some tests 😄. Doesn't add in 100% coverage on any file or really finish any of the linked issues. Just raises test coverage across the board in general.