Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve the release docs workflow #254

Merged
merged 16 commits into from
Dec 24, 2023
Merged

Conversation

RebeccaStevens
Copy link
Collaborator

@RebeccaStevens RebeccaStevens commented Aug 12, 2023

PR Checklist

Overview

The same issue as RebeccaStevens/uom-types#55

Before Merge

gh-pages branch need to be created. Create with:

git switch --orphan gh-pages
git commit --allow-empty -m "initial docs" --no-verify
git push

@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5081005) 80.22% compared to head (0d34d4d) 80.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #254   +/-   ##
=======================================
  Coverage   80.22%   80.22%           
=======================================
  Files          35       35           
  Lines        6406     6406           
  Branches      360      360           
=======================================
  Hits         5139     5139           
  Misses       1267     1267           
Flag Coverage Δ
4.3.5 80.00% <ø> (ø)
4.6.4 80.03% <ø> (ø)
4.9.5 80.03% <ø> (ø)
latest 80.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RebeccaStevens
Copy link
Collaborator Author

Hmm, not sure if there's a nice way to ignore those spelling issues other than just adding the detected words to the cspell dictionary.

@RebeccaStevens RebeccaStevens force-pushed the release-docs-fix branch 2 times, most recently from 29cb68b to c63dd32 Compare August 12, 2023 11:23
package.json Outdated Show resolved Hide resolved
@RebeccaStevens
Copy link
Collaborator Author

RebeccaStevens commented Aug 14, 2023

Pushed a new update that rework the docs workflows a bit. They aren't fully tested as testing workflows is hard, but hopefully they work as intended.

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! This is getting a bit complicated and long term I think it'd be nice to extract the logic out into its own reusable workflows. But for now it feels reasonable to just go with it. Thanks!

.github/workflows/docs-release.yml Outdated Show resolved Hide resolved
.github/workflows/docs-update.yml Outdated Show resolved Hide resolved
.github/workflows/docs-update.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author Needs an action taken by the original poster label Aug 18, 2023
@JoshuaKGoldberg
Copy link
Owner

👋 ping @RebeccaStevens, is this something you're interested in and have time for?

@RebeccaStevens
Copy link
Collaborator Author

What's the status of this? What needs doing?

@JoshuaKGoldberg
Copy link
Owner

I'd left a few questions for you in comment threads. I'm up for merging as-is with the suggested touchups, but didn't want to steamroll past you. 🙂

@RebeccaStevens
Copy link
Collaborator Author

RebeccaStevens commented Dec 23, 2023

I've rebased this off #341 and made a few updates.
This PR should be pretty much ready now.

Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! Let's give this a shot. 🚀

@JoshuaKGoldberg JoshuaKGoldberg merged commit 9e79406 into main Dec 24, 2023
23 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the release-docs-fix branch December 24, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for author Needs an action taken by the original poster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 CI: release_docs/update_and_deploy_docs is failing
2 participants