-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update & simplify knip config #416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks - much appreciated! I'll defer to @RebeccaStevens as they set up the two Knip configs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #416 +/- ##
==========================================
+ Coverage 80.19% 80.38% +0.18%
==========================================
Files 35 35
Lines 6575 6575
Branches 432 437 +5
==========================================
+ Hits 5273 5285 +12
+ Misses 1302 1290 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Looks like this didn't auto merge. Edit: looks like I can't @JoshuaKGoldberg could you merge this? |
I think I figured out that the PR description did not match the template (there was no "fixes" or "resolves" keyword). Updated it. |
@all-contributors please add @webpro for code.
|
I've put up a pull request to add @webpro! 🎉 I couldn't determine any contributions to add, did you specify any contributions? |
PR Checklist
status: accepting prs
(I guess it should be listed here?)Overview
Since Knip v4, the
classMembers
issue type should be enabled explicitly. That introduces the reportedfinish
issue in--production
mode, which unfortunately is still not fixed, but at least we can now ignore only that specific member. And merge two configs into one :)