Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update & simplify knip config #416

Merged
merged 6 commits into from
May 6, 2024

Conversation

webpro
Copy link
Contributor

@webpro webpro commented Mar 27, 2024

PR Checklist

Overview

Since Knip v4, the classMembers issue type should be enabled explicitly. That introduces the reported finish issue in --production mode, which unfortunately is still not fixed, but at least we can now ignore only that specific member. And merge two configs into one :)

@webpro webpro marked this pull request as ready for review March 27, 2024 06:11
@webpro webpro changed the title Simplify knip config into a single file chore: update & simplify knip config Mar 27, 2024
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks - much appreciated! I'll defer to @RebeccaStevens as they set up the two Knip configs.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.38%. Comparing base (a498fc2) to head (5ac5dda).
Report is 3 commits behind head on main.

❗ Current head 5ac5dda differs from pull request most recent head e6b36b5. Consider uploading reports for the commit e6b36b5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
+ Coverage   80.19%   80.38%   +0.18%     
==========================================
  Files          35       35              
  Lines        6575     6575              
  Branches      432      437       +5     
==========================================
+ Hits         5273     5285      +12     
+ Misses       1302     1290      -12     
Flag Coverage Δ
4.3.5 80.16% <ø> (?)
4.6.4 80.19% <ø> (?)
4.9.5 80.19% <ø> (ø)
latest 80.16% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

knip.jsonc Outdated Show resolved Hide resolved
knip.jsonc Outdated Show resolved Hide resolved
@RebeccaStevens RebeccaStevens enabled auto-merge (squash) April 5, 2024 07:13
@RebeccaStevens
Copy link
Collaborator

RebeccaStevens commented May 6, 2024

Looks like this didn't auto merge. I'll merge it now.

Edit: looks like I can't @JoshuaKGoldberg could you merge this?

@RebeccaStevens RebeccaStevens enabled auto-merge (squash) May 6, 2024 09:48
@webpro
Copy link
Contributor Author

webpro commented May 6, 2024

I think I figured out that the PR description did not match the template (there was no "fixes" or "resolves" keyword). Updated it.

@RebeccaStevens RebeccaStevens merged commit e0206dd into JoshuaKGoldberg:main May 6, 2024
21 of 22 checks passed
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @webpro for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @webpro! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@webpro webpro deleted the knip-config branch May 6, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Knip reporting a false positive on NamespaceScope's finish
3 participants