Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SaveSolutionCallback #44

Merged
merged 20 commits into from
May 4, 2024
Merged

Add SaveSolutionCallback #44

merged 20 commits into from
May 4, 2024

Conversation

JoshuaLampert
Copy link
Owner

Save solution during time integration to .vtu and .pvd files.

only depend on space, not on time
they changed because with the PeriodicCallback additional time steps are taken
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (4970841) to head (e08ab84).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   98.72%   98.71%   -0.02%     
==========================================
  Files          29       32       +3     
  Lines         865      933      +68     
==========================================
+ Hits          854      921      +67     
- Misses         11       12       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaLampert
Copy link
Owner Author

This ended up in a compat battle. Everything started with needing to bump julia to v1.9 because the finalize function of the callbacks needs at least OrdinaryDiffEq.jl v6.59.3, which in turn needs julia v1.9. After a nightmare of incompatibilities, I ended up bumping the julia compat to v.1.10 and some other compat bumps.

@JoshuaLampert JoshuaLampert merged commit a72dbdf into main May 4, 2024
13 of 14 checks passed
@JoshuaLampert JoshuaLampert deleted the write-pvd-files branch May 4, 2024 18:49
@JoshuaLampert JoshuaLampert added the enhancement New feature or request label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant