[Delivers #158791391] API v2 Signup Endpoint #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaOndieki
added
the
Feedback Wanted
Repository owner
deleted a comment
Jul 3, 2018
Repository owner
deleted a comment
Jul 3, 2018
Repository owner
deleted a comment
Jul 3, 2018
Repository owner
deleted a comment
Jul 3, 2018
Repository owner
deleted a comment
Jul 3, 2018
Repository owner
deleted a comment
Jul 3, 2018
Repository owner
deleted a comment
Jul 3, 2018
Repository owner
deleted a comment
Jul 3, 2018
Repository owner
deleted a comment
Jul 3, 2018
Repository owner
deleted a comment
Jul 3, 2018
Repository owner
deleted a comment
Jul 3, 2018
Repository owner
deleted a comment
Jul 3, 2018
Repository owner
deleted a comment
Jul 3, 2018
Repository owner
deleted a comment
Jul 3, 2018
Repository owner
deleted a comment
Jul 3, 2018
Repository owner
deleted a comment
Jul 4, 2018
Repository owner
deleted a comment
Jul 4, 2018
Repository owner
deleted a comment
Jul 4, 2018
Repository owner
deleted a comment
Jul 4, 2018
Repository owner
deleted a comment
Jul 4, 2018
Repository owner
deleted a comment
Jul 4, 2018
|
Why are the tests failing? |
xcixor
reviewed
Jul 4, 2018
ridemyway/utils/db_queries.py
Outdated
| sql = """INSERT INTO | ||
| appuser (username, name, gender, usertype, date_joined, | ||
| contacts, email, password) | ||
| VALUES ('%s','%s','%s','%s', '%s', %d, '%s', '%s')""" % ( |
There was a problem hiding this comment.
You can also use the string.format() method to insert the data
kwameasiago
reviewed
Jul 4, 2018
ridemyway/api/v2/controllers/auth.py
Outdated
|
|
||
| def signup(self, **kwargs): | ||
| """ | ||
|
|
ridemyway/__init__.py
Outdated
| @@ -47,14 +48,7 @@ def create_app(config_name): | |||
| app.database = DATABASE | |||
| app.config.from_object(config[config_name]) | |||
| app.config['BUNDLE_ERRORS'] = True | |||
There was a problem hiding this comment.
Its good practice to put all your configurations in the config file
Repository owner
deleted a comment
Jul 4, 2018
Repository owner
deleted a comment
Jul 4, 2018
Repository owner
deleted a comment
Jul 4, 2018
Repository owner
deleted a comment
Jul 4, 2018
Repository owner
deleted a comment
Jul 4, 2018
Repository owner
deleted a comment
Jul 4, 2018
Repository owner
deleted a comment
Jul 4, 2018
Repository owner
deleted a comment
Jul 4, 2018
Repository owner
deleted a comment
Jul 4, 2018
Repository owner
deleted a comment
Jul 4, 2018
Repository owner
deleted a comment
Jul 4, 2018
LWanjiru
approved these changes
Jul 4, 2018
ridemyway/utils/db_queries.py
Outdated
| app.conn.commit() | ||
| return True | ||
| except psycopg2.Error: | ||
| print('Roll back, user not added') |
Repository owner
deleted a comment
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds signup endpoint to the API
Description of Task to be completed
Adding a signup endpoint to allow drivers | riders to sign up
POST
/api/v2/auth/signupTasks achieved in this PR
/api/v2/auth/signupHow should one test this endpoint?
git clone https://github.com/JoshuaOndieki/ridemyway-api.gitgit checkout ft-signup-158791391nosetests ridemyway/tests/test_v2/test_auth/test_signup.pyto see the signup tests pass. Alternatively, runpytest ridemyway/tests/test_v2/test_auth/test_signup.pyBut why is the build failing 😕 ?
The build is also testing endpoints which are yet to be implemented. Bear with me while I implement them.
How can you help?
Review my work and let me know any semantic, technical or syntax/standards errors I may have.
I will greatly appreciate any feature/change suggestions too 😃
Resources & Libs
This Pivotal Tracker board was used to plan and manage the tasks.
Relevant PIvotal Tracker Stories?
#158791391