[Delivers #158623810] Challenge 2 completed and hosted on heroku #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename test_does_not_fetch_single_ride_that_does_not_exist to test_does_not_fetch_ride_that_does_not_exist
[Finishes #158592619] [Finishes #158592679]
[Chore] Test api endpoints [WIP]
…7497 [Chore #158607497] Setup flask restful
|
Code Climate has analyzed commit a21ef67 and detected 0 issues on this pull request. View more on Code Climate. |
Repository owner
deleted a comment
Jun 28, 2018
Repository owner
deleted a comment
Jun 28, 2018
Repository owner
deleted a comment
Jun 28, 2018
Repository owner
deleted a comment
Jun 28, 2018
Pull Request Test Coverage Report for Build 121
💛 - Coveralls |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| from .response import Response | ||
|
|
||
|
|
||
| def create_ride(**kwargs): |
There was a problem hiding this comment.
Function create_ride has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
| Controls all CRUD operations of the Request object. | ||
| """ | ||
|
|
||
| def create_request(self, **kwargs): |
There was a problem hiding this comment.
Function create_request has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Repository owner
deleted a comment
Jun 28, 2018
Repository owner
deleted a comment
Jun 28, 2018
Repository owner
deleted a comment
Jun 28, 2018
Repository owner
deleted a comment
Jun 28, 2018
Repository owner
deleted a comment
Jun 28, 2018
Repository owner
deleted a comment
Jun 28, 2018
| Controls all CRUD operations of the Request object. | ||
| """ | ||
|
|
||
| def create_request(self, **kwargs): |
There was a problem hiding this comment.
Function create_request has 26 lines of code (exceeds 25 allowed). Consider refactoring.
|
Good job |
xcixor
approved these changes
Jun 28, 2018
…eki/ridemyway-api into ft-api-docs-158650274
[Delivers #158650274] API Documentation
JoshuaOndieki
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Completes challenge 2 with working endpoints.
Description of Task to be completed
Add working and tested endpoints as required in challenge 2.
Endpoints created and tested?
/api/v1/rides/api/v1/rides/api/v1/rides/<rideId>/api/v1/auth/rides/<rideId>/requestsTasks achieved in this PR
How should this be manually tested?
git clone https://github.com/JoshuaOndieki/ridemyway-api.gitgit checkout developnosetests --with-coverage --cover-package=ridemywayto see the tests pass and coverageBackground Context?
My approach assumes no users and therefore rides can be created and requests made without user interaction.
Resources & Libs
This Pivotal Tracker board was used to plan and manage the tasks.