Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Delivers #158791699] Get User API Endpoint #32

Merged
merged 26 commits into from
Jul 6, 2018

Conversation

JoshuaOndieki
Copy link
Owner

@JoshuaOndieki JoshuaOndieki commented Jul 6, 2018

What does this PR do?
Adds get user endpoint to the API

Description of Task to be completed
A user should be able to fetch public profiles of other users

GET /api/v2/users/<username>

Tasks achieved in this PR

  • GET /api/v2/users/<username>

How should one test this endpoint?

  • Clone this repo using git clone https://github.com/JoshuaOndieki/ridemyway-api.git
  • Check the ReadMe for instructions on setting up the project.
  • git checkout ft-get-user-158791699
  • Run nosetests to see the tests pass. Alternatively, run pytest

How can you help?
Review my work and let me know any semantic, technical or syntax/standards errors I may have.
I will greatly appreciate any feature/change suggestions too 😃

Resources & Libs
This Pivotal Tracker board was used to plan and manage the tasks.

Relevant PIvotal Tracker Stories?
#158791699

Screenshots

screenshot from 2018-07-06 03-04-37

@coveralls
Copy link

coveralls commented Jul 6, 2018

Pull Request Test Coverage Report for Build 240

  • 151 of 163 (92.64%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 95.672%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ridemyway/tests/tests_v2/test_auth/test_logout.py 15 16 93.75%
ridemyway/api/v2/resources.py 29 30 96.67%
ridemyway/tests/tests_v2/test_auth/test_login.py 31 32 96.88%
ridemyway/tests/tests_v2/test_user/test_fetch_user.py 14 15 93.33%
ridemyway/utils/errors.py 7 10 70.0%
ridemyway/api/v2/jwtblacklist.py 0 5 0.0%
Totals Coverage Status
Change from base Build 202: -0.9%
Covered Lines: 641
Relevant Lines: 670

💛 - Coveralls

Repository owner deleted a comment Jul 6, 2018
Repository owner deleted a comment Jul 6, 2018
Repository owner deleted a comment Jul 6, 2018
Repository owner deleted a comment Jul 6, 2018
@JoshuaOndieki JoshuaOndieki merged commit f025e1d into develop Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants