Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved first-run experience #20

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Improved first-run experience #20

merged 1 commit into from
Jan 11, 2021

Conversation

JostMigenda
Copy link
Member

@JostMigenda JostMigenda commented Jan 5, 2021

Inspired by this comment by @bradkav in the JOSS review.
This adds an sntools.setup() function that users should run immediately after installing sntools. It downloads the sample input file used in examples in the documentation and runs an integration test to verify that sntools works and gives the expected results.

Add sntools.setup() function to download sample input file and perform integration test.
@bradkav
Copy link

bradkav commented Jan 11, 2021

This looks great to me. I've checked that sntools.setup() works and that the flux files required for the examples are now downloaded. I'll check off the 'tests' and 'examples' items in my review ✅

@JostMigenda JostMigenda merged commit 565b3b0 into master Jan 11, 2021
@JostMigenda JostMigenda deleted the JostMigenda/firstrun branch January 11, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants