Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ExternalLink look like it should for regular text #148

Closed
nlitwin opened this issue Jul 5, 2020 · 0 comments · Fixed by #149
Closed

Make ExternalLink look like it should for regular text #148

nlitwin opened this issue Jul 5, 2020 · 0 comments · Fixed by #149
Assignees
@nlitwin
Labels
bug Something isn't working frontend Frontend work!
Projects
Master Board
Milestone
Launch Beta! 🎉

Comments

@nlitwin
Copy link
Contributor

nlitwin commented Jul 5, 2020

Description

We recently added the ExternalLink component to handle anchor tags to external sites outside of the Journaly domain. Right now it's working for links that are icons, but for regular text, it's rendering as a block level element. It also needs the right color for anchor tags in text.

Repro Steps

  1. Use the ExternalLink around regular text
@nlitwin nlitwin added bug Something isn't working frontend Frontend work! labels Jul 5, 2020
@nlitwin nlitwin added this to the Launch Beta! 🎉 milestone Jul 5, 2020
@nlitwin nlitwin self-assigned this Jul 5, 2020
@nlitwin nlitwin added this to To do in Master Board via automation Jul 5, 2020
@robin-macpherson robin-macpherson moved this from To do to Done in Master Board Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nlitwin nlitwin

Labels
bug Something isn't working frontend Frontend work!
Projects
Master Board
  
Done
Milestone
Launch Beta! 🎉
Development

Successfully merging a pull request may close this issue.

Update the ExternalLink component Journaly/journaly
1 participant
@nlitwin