Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Post background color and header/image width #158

Merged
merged 1 commit into from Jul 12, 2020
Merged

Fix Post background color and header/image width #158

merged 1 commit into from Jul 12, 2020

Conversation

robin-macpherson
Copy link
Contributor

@robin-macpherson robin-macpherson commented Jul 12, 2020 •
edited

Description

Issue: closes #157

Fixes a couple of visual bugs with the Post:

  • background should be white
  • image/header should be full-width

How To Test

  1. Go to the "✅ Preview" link from the Vervel build (🤩🤩🤩)
  2. Log in and click on any post in your gawjus feed
  3. See that the post background is white and the header image is now full-width and totally beauwtiful 🥰

Before

image

Now

image

Subtasks

  • I have added this PR to the Journaly Kanban project ✅
  • Update background color
  • Find issue with image/header and fix it

@vercel
Copy link

vercel bot commented Jul 12, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/journaly/journaly/hf3kwdg08
✅ Preview: https://journaly-git-robin-small-improvements.journaly.vercel.app

@github-actions github-actions bot added the frontend Frontend work! label Jul 12, 2020
@robin-macpherson robin-macpherson self-assigned this Jul 12, 2020
@robin-macpherson robin-macpherson added this to In progress in Master Board via automation Jul 12, 2020
@robin-macpherson robin-macpherson added this to the Launch Beta! 🎉 milestone Jul 12, 2020
@robin-macpherson
Copy link
Contributor Author

@nlitwin @Lanny please note the "how to test" steps and workflow 🤩

@nlitwin
Copy link
Contributor

nlitwin commented Jul 12, 2020

So coool!!!

@robin-macpherson robin-macpherson merged commit 18e37e0 into master Jul 12, 2020
Master Board automation moved this from In progress to Done Jul 12, 2020
@robin-macpherson robin-macpherson deleted the robin/small-improvements branch July 12, 2020 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlitwin nlitwin nlitwin approved these changes

@Lanny Lanny Awaiting requested review from Lanny

Assignees

@robin-macpherson robin-macpherson

Labels
frontend Frontend work!
Projects
Master Board
  
Done
Milestone
Launch Beta! 🎉
Development

Successfully merging this pull request may close these issues.

Post background should be white and header/image should be full-width
2 participants
@robin-macpherson @nlitwin