Fix dialogic-godot#2248

Jowan-Spooner · May 23, 2024 · 3150904 · 3150904
1 parent 11a1a41
commit 3150904
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/addons/dialogic/Modules/Character/subsystem_portraits.gd b/addons/dialogic/Modules/Character/subsystem_portraits.gd
@@ -277,7 +277,7 @@ func get_valid_portrait(character:DialogicCharacter, portrait:String) -> String:
 		return ""
 
 	if "{" in portrait and dialogic.has_subsystem("Expressions"):
-		var test := dialogic.Expressions.execute_string(portrait)
+		var test: Variant = dialogic.Expressions.execute_string(portrait)
 		if test:
 			portrait = str(test)
 

diff --git a/addons/dialogic/Modules/DefaultLayoutParts/Layer_Textbubble/text_bubble.gd b/addons/dialogic/Modules/DefaultLayoutParts/Layer_Textbubble/text_bubble.gd
@@ -51,8 +51,8 @@ func _process(delta:float) -> void:
 
 	var center := get_viewport_rect().size / 2.0
 
-	var dist_x := abs(base_position.x - center.x)
-	var dist_y := abs(base_position.y - center.y)
+	var dist_x := absf(base_position.x - center.x)
+	var dist_y := absf(base_position.y - center.y)
 	var x_e := center.x - bubble_rect.size.x
 	var y_e := center.y - bubble_rect.size.y
 	var influence_x := remap(clamp(dist_x, x_e, center.x), x_e, center.x * 0.8, 0.0, 1.0)

diff --git a/addons/dialogic/Modules/Text/node_dialog_text.gd b/addons/dialogic/Modules/Text/node_dialog_text.gd
@@ -35,8 +35,6 @@ func _set(property: StringName, what: Variant) -> bool:
 		return true
 	return false
 
-	return false
-
 
 func _ready() -> void:
 	# add to necessary