Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substrate vs Joystream address format UX upd #3256

Closed
3 tasks
kdembler opened this issue Sep 15, 2022 · 2 comments
Closed
3 tasks

Substrate vs Joystream address format UX upd #3256

kdembler opened this issue Sep 15, 2022 · 2 comments
Assignees
Labels
carthage Carthagne Network onboarding ux User Experience

Comments

@kdembler
Copy link
Member

kdembler commented Sep 15, 2022

Scope

  • Update the designs of the Transfer Modal as per this comment
  • Update the validation to accept both Substrate generic and Joystream Specific addresses.
  • Convert the address to Joystream format before sending an extrinsic

Context

Polkadot wallet address vs Joystream wallet address
Designs for the Transfer dialog have been created around the assumption that JOY tokens can be transferred from one Polkadot wallet to another; therefore, it's the Polkadot wallet address that's an identifier of a destination account. (link) In the implementation, to my surprise, the "Polkadot wallet address" has been swapped with "Joystream wallet address".

Now, "Joystream wallet address" is a concept to which I, as an Atlas user, haven't been properly introduced to yet, meaning (a) I don't know what's my Joystream wallet address or (b) where to find it.

Unless changing "Polkadot wallet address" to "Joystream wallet address" isn't trivial (no one talked to me about it) and is necessary for the Transfer dialog to work, I believe we must create an issue to think about onboarding Atlas users with the concept of Joystream wallet addresses, it's relation with Polkadot wallet addresses and how does transfering funds work in general. And for that to happen, I'd need to be onboarded with that knowledge myself, too.

@dmtrjsg @kdembler If you guys agree with the above, I'd appreciate pointing me to further reading on the subject, if it's available (I tried looking it up in our Handbook, but I haven't found anything), or arranging a meeting where I can have someone explain this to me.

@toiletgranny
Copy link
Contributor

toiletgranny commented Oct 5, 2022

@kdembler Having talked to you about this and having read a few articles on the subject, my recommendation is as follows:

  1. In the Transfer dialog, in the Destination account text field, let's bring back the "Polkadot wallet address" placeholder, as it's more technically accurate.
    • The current "Joystream wallet address" placeholder implies that only Polkadot wallet addresses in the Joystream format are accepted by the form, which is not the case.
  2. In the Transfer dialog, in the Destination account text field, let's add a tooltip briefly explaining multiple wallet address formats. Designs, docs, and documentation can be found here.

image

cc @dmtrjsg

@toiletgranny toiletgranny assigned kdembler and unassigned toiletgranny Oct 5, 2022
@dmtrjsg
Copy link

dmtrjsg commented Oct 6, 2022

Agree with the design implementation.

⚠️ Just to add that both formats should be accepted in the destination account. Lets update the validation on prefix, but remove the char length from the validation.

@kdembler kdembler removed the design label Oct 10, 2022
@kdembler kdembler removed their assignment Oct 10, 2022
@kdembler kdembler added the carthage Carthagne Network label Oct 10, 2022
@rafalpawlow rafalpawlow self-assigned this Oct 11, 2022
@dmtrjsg dmtrjsg changed the title Substrate vs Joystream address format Substrate vs Joystream address format UX upd Oct 20, 2022
@dmtrjsg dmtrjsg added the ux User Experience label Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carthage Carthagne Network onboarding ux User Experience
Projects
None yet
Development

No branches or pull requests

4 participants