Textfield select #297
Merged
Textfield select #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkio-j
reviewed
Feb 4, 2021
drillprop
force-pushed
the
textfield-select
branch
from
0646911
to
454a663
Compare
drillprop
commented
Feb 8, 2021
kdembler
reviewed
Feb 9, 2021
kdembler
approved these changes
Feb 9, 2021
kdembler
pushed a commit
to kdembler/atlas
that referenced
this pull request
May 24, 2021
* install downshift * create InputBase component * update colors * create Select and TextField component * fix imports * update Select props * fix Select for CR * fix TextField for CR * fix label transition in text field * fix helperText logic * refactor TextField * add story with uncontrolled input * minor improvements to TextField stories * styling updates for inputbase and select * cr fixes
kdembler
pushed a commit
that referenced
this pull request
May 26, 2021
* install downshift * create InputBase component * update colors * create Select and TextField component * fix imports * update Select props * fix Select for CR * fix TextField for CR * fix label transition in text field * fix helperText logic * refactor TextField * add story with uncontrolled input * minor improvements to TextField stories * styling updates for inputbase and select * cr fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #240