Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛝 CRT Ratio Slider #4470

Merged
merged 6 commits into from
Jul 26, 2023
Merged

🛝 CRT Ratio Slider #4470

merged 6 commits into from
Jul 26, 2023

Conversation

Copy link
Contributor

@WRadoslaw WRadoslaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice approach and work!

@thesan
Copy link
Member Author

thesan commented Jul 21, 2023

Wow, nice approach and work!

Thanks. I had just started implementing the draggable element when realized I could just use the range input directly, and to my surprised it works on mobile browsers !

@attemka attemka added the don't merge PRs that couldn't be merged for some reason label Jul 25, 2023
@WRadoslaw WRadoslaw changed the base branch from dev to crt July 26, 2023 13:03
@attemka attemka merged commit a7c5f62 into Joystream:crt Jul 26, 2023
4 checks passed
WRadoslaw pushed a commit that referenced this pull request Mar 5, 2024
* Add the RatioSlider component

* Add a story

* Annimate the transitions

* Rename the svg mask

* Fix the RatioSliderProps type name

* Fix the active steps class name
WRadoslaw pushed a commit that referenced this pull request Mar 14, 2024
* Add the RatioSlider component

* Add a story

* Annimate the transitions

* Rename the svg mask

* Fix the RatioSliderProps type name

* Fix the active steps class name
WRadoslaw pushed a commit that referenced this pull request Mar 14, 2024
* Add the RatioSlider component

* Add a story

* Annimate the transitions

* Rename the svg mask

* Fix the RatioSliderProps type name

* Fix the active steps class name
WRadoslaw pushed a commit to WRadoslaw/atlas that referenced this pull request Apr 22, 2024
* Add the RatioSlider component

* Add a story

* Annimate the transitions

* Rename the svg mask

* Fix the RatioSliderProps type name

* Fix the active steps class name
WRadoslaw pushed a commit to WRadoslaw/atlas that referenced this pull request Apr 22, 2024
* Add the RatioSlider component

* Add a story

* Annimate the transitions

* Rename the svg mask

* Fix the RatioSliderProps type name

* Fix the active steps class name
WRadoslaw pushed a commit to Joystream/gleev that referenced this pull request Apr 22, 2024
* Add the RatioSlider component

* Add a story

* Annimate the transitions

* Rename the svg mask

* Fix the RatioSliderProps type name

* Fix the active steps class name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't merge PRs that couldn't be merged for some reason
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants