Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telegram bot bugs + improvements #10

Closed
mochet opened this issue Aug 12, 2020 · 12 comments
Closed

Telegram bot bugs + improvements #10

mochet opened this issue Aug 12, 2020 · 12 comments
Labels
bug Something isn't working telegram-bot

Comments

@mochet
Copy link
Collaborator

mochet commented Aug 12, 2020

Now that the bot is live, it will hopefully be easier for people to propose/improve upon it. We could hopefully create small bounties for these.

  • The proposal notification Title field is actually taking from description/rationale. There is a title field and it should be what is shown.
  • When announcing a new election cycle or stage, it would be nice for the bot to include a rough indication in human readable format of the time this stage will be active for. (ex. "This phase lasts for ~24h")
  • A reminder notification for highly important events, like election announce period would be great. The current announce period is 24h, so after the initial bot notification a reminder could be made at 16h to ensure people in different time zones are aware.
@mochet
Copy link
Collaborator Author

mochet commented Aug 16, 2020

More issues/improvements:

  • New thread creates 2x announcements, one for the new thread and one for the 1st post. This is redundant and causes spam on Telegram.
  • It seems there is a rare bug where a post/thread might be displayed twice, the screenshot below shows that the post IDs were different, but only one of them actually exists:
    image

@mochet
Copy link
Collaborator Author

mochet commented Aug 16, 2020

Suggested by @bedeho :

  • Add a list of members correlated with their Telegram handles. When reminder notifications are made for proposals, the bot can tag specific users who have not voted yet for proposals.

Ideally the list would just be a text file or something very easy to modify.

@mochet
Copy link
Collaborator Author

mochet commented Aug 23, 2020

There is an issue where two notifications are made when a proposal executes, it looks like it takes a future block number for the execution which hasn't happened yet (its a spending proposal, so there is a grace period attached):
image

@mochet
Copy link
Collaborator Author

mochet commented Aug 24, 2020

A missing feature is that comments left on proposals are not announced by the Telegram bot. This would be a nice feature to have as otherwise people are not aware of comments being made in this area of the platform, unlike the forum section it does not have a recent activity list.

@bitoven-dev
Copy link
Contributor

Yes, there are many improvements that can be made. I actually only try to meet the KPI requirements at first. So it is on the minimal feature.
Also I want to know, what are the steps for further improvement of the bot (or maybe all of the existing community repo)?
Do we need to create proposal again or we can just directly make pull request for it?

@mochet
Copy link
Collaborator Author

mochet commented Aug 28, 2020

Also I want to know, what are the steps for further improvement of the bot (or maybe all of the existing community repo)?
Do we need to create proposal again or we can just directly make pull request for it?

This was discussed in the initial improvement of the community repo: https://github.com/Joystream/community-repo
It is likely in the future we will have to accomodate revisions and improvements of previous submissions. This process will be refined when this becomes a necessary task.

So there is no actual process for this yet. I think for minor changes it really shouldn't require a proposal, but for major improvements/changes, especially those asking for funding, there should be a proposal made. I'll create a forum thread to discuss this.

@mochet
Copy link
Collaborator Author

mochet commented Aug 28, 2020

Another feature that would be nice to have is some scripts be able to return a value, for instance the HELIOS script which returns information about current storage providers, could be accessed by someone typing !HELIOS in chat (or whatever method works for triggering the script to run and return its value).

@mochet
Copy link
Collaborator Author

mochet commented Aug 31, 2020

  • The Kusama network has an interesting bot that posts network stats, this is triggered by a user inputting a command to run the bot. it can also be refreshed: image
  • The bot sometimes misses forum posts, but it will notify of a forum post made only a few minutes later

@bitoven-dev
Copy link
Contributor

Now, the forum has more activities, the double bug is surely become annoying. Especially on double proposal bug that was breaking/stopping the bot
I think I just have an idea to solve the double bug on telegram bot, that is by parsing new event with api.query.system.events and only then it will notify the telegram.
Currently what the bot doing is querying forum.nextPostId and then calculate the current post id. And compare for any change on forum.nextPostId
This fix, I believe is also more efficient and consuming less resource
But it will more or less rewrite most of the code. 😅
I just want to make sure that all of events can be found on https://testnet.joystream.org/#/explorer (api.query.system.events), right @bwhm ?

@bwhm
Copy link
Member

bwhm commented Aug 31, 2020

Yes, there are many improvements that can be made. I actually only try to meet the KPI requirements at first. So it is on the minimal feature.
Also I want to know, what are the steps for further improvement of the bot (or maybe all of the existing community repo)?
Do we need to create proposal again or we can just directly make pull request for it?

When the new KPI system is out, improving the telegram bot will surely be included!

Before then, I don't think we'll have time to focus on it...

@bwhm
Copy link
Member

bwhm commented Aug 31, 2020

Now, the forum has more activities, the double bug is surely become annoying. Especially on double proposal bug that was breaking/stopping the bot
I think I just have an idea to solve the double bug on telegram bot, that is by parsing new event with api.query.system.events and only then it will notify the telegram.
Currently what the bot doing is querying forum.nextPostId and then calculate the current post id. And compare for any change on forum.nextPostId
This fix, I believe is also more efficient and consuming less resource
But it will more or less rewrite most of the code. 😅
I just want to make sure that all of events can be found on https://testnet.joystream.org/#/explorer (api.query.system.events), right @bwhm ?

If you mean whether the explorer tab will display add all new events as they come in, then no. Click on a block, and you'll see there are more. It should show all non-trivial ones, but I haven't double checked that...

@mochet mochet added the bug Something isn't working label Nov 3, 2020
@mochet
Copy link
Collaborator Author

mochet commented Nov 3, 2020

Since there is now a new bot, I will close this issue and we can move discussion to: #38

@mochet mochet closed this as completed Nov 3, 2020
freakstatic added a commit to freakstatic/community-repo that referenced this issue Jun 29, 2021
mochet added a commit that referenced this issue Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working telegram-bot
Projects
None yet
Development

No branches or pull requests

4 participants