Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example: Integrating example-module into runtime #57

Closed

Conversation

mnaamani
Copy link
Member

@mnaamani mnaamani commented May 7, 2019

== THIS PR IS FOR DEMONSTRATION ONLY - DO NOT MERGE ==

Example of how to integrate an external module into the runtime.

Demonstrates how to apply the recommended convention to make a module easily reusable for another runtime, by providing your own traits for your expectations on other modules, rather than relying on public traits, or traits in the module you are expecting to use. In this example we apply this to the "membership" system.

git = 'https://github.com/joystream/runtime-example-module.git'
default_features = false
rev = 'a14d1433ab9691170cd0b68fd6a82197ee7c61b9'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During development before pushing a repo you might also want to use a path dependency:

[dependencies.runtime-example-module]
path = '../path-to-local-repo/example-module'
default_features = false

https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-path-dependencies

@mnaamani
Copy link
Member Author

closing as it is for demonstration purposes only

@mnaamani mnaamani closed this Jun 18, 2019
mnaamani added a commit to mnaamani/joystream that referenced this pull request Mar 20, 2020
Lezek123 pushed a commit to Lezek123/substrate-runtime-joystream that referenced this pull request May 21, 2020
* Use componentDidUpdate for change triggers

* Update dependencies
@mnaamani mnaamani deleted the example-module-integration branch May 22, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant