Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qnode new format for event name #1073

Merged
merged 7 commits into from
Aug 27, 2020
Merged

Qnode new format for event name #1073

merged 7 commits into from
Aug 27, 2020

Conversation

metmirr
Copy link
Contributor

@metmirr metmirr commented Jul 28, 2020

This PR changes event handler naming convention from handle<EventName> to <runtimeModule><EventName>. There are same event names across runtime modules so we need to make sure each event handler name is unique. For example, in Kusama network, we can see that the treasury and balances module both have an event named Deposit.

@dzhelezov
Copy link
Contributor

It feels safer to me if we still leave a separator between the module and method, like an underscore. The method then would look like treasury_TipProposed and so is the event name. It might be useful to be able to decode the module and the method by simply looking at the event name, and if there is no delimiter it becomes ambiguous.

@metmirr
Copy link
Contributor Author

metmirr commented Aug 27, 2020

It feels safer to me if we still leave a separator between the module and method, like an underscore. The method then would look like treasury_TipProposed and so is the event name. It might be useful to be able to decode the module and the method by simply looking at the event name, and if there is no delimiter it becomes ambiguous.

Done!

@bedeho bedeho merged commit 5e378c5 into Joystream:query_node Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants