Migrate monorepo to development branch #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rome version of hiring module
Added activation and deactivation of relationships
rustfmt + update dependency
- fix redundant field names in struct initialization - change assert!(false) to panic! with comments
- fix using `clone` on a `Copy` type - fix match on a boolean expression - fix passing small enum by reference - fix typos
- rustfmt - fix doc comments
- upgrade to directory - introduce application, opening, staking_policy submodules - copy related code to the new modules - implement several macro’s as generic functions
- move application and opening entities to related modules - move staking_policy methods to staking_policy module
- fix very complex type warning
- altered add_application - altered deactive_application
Cover main hiring workflow: 1. add_opening 2. add_application 3. begin_review 4. fill_opening
- remove comment - add check for application is not crowded out - add more comments to checks
- add ensure_can_add_application basic check - add more comments
- add wiki ling to smoke-test concept
- mark ‘macroes’ mod with #[macro_use] - remove all #[macro_export]
- move out opening checks from lib.rs to opening.rs - move out opening construction to opening.rs (as ::new() constructor) - delete obsolete macro ensure_amount_valid_in_opt_staking_policy
- improve readability of call_and_assert() - check content asserts inside call_and_assert() - revert error handling back to assert!
- add tests for begin_accepting_applications - add test for add_opening with Exact block activation - commented empty tests for future use in mod.rs
- move out code from lib.rs to opening.rs - mark some pub methods as crate-only
…rnal_modules # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…nal_modules # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…norepo_external_modules # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Hiring module migration to the monorepo branch.
External joystream modules migrated to the runtime monorepo.
Monorepo update from development
# Conflicts: # Cargo.lock # Cargo.toml
Monorepo workspace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after updating monorepo to a cargo worksapce