Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevOps - Deploy Joystream node network on EKS with Kubernetes and Pulumi #2533

Merged
merged 10 commits into from Aug 2, 2021

Conversation

ahhda
Copy link
Contributor

@ahhda ahhda commented Jul 16, 2021

Related to #2406

Refer to README for instructions on how to deploy

Manual testing

Screenshot 2021-07-28 at 2 17 25 PM

@ahhda ahhda changed the title DevOps - Deploy Joystream node network on EKS with Kubernetes and Pulumi [WIP] DevOps - Deploy Joystream node network on EKS with Kubernetes and Pulumi Jul 21, 2021
@mnaamani mnaamani self-requested a review July 21, 2021 15:08
Copy link
Contributor

@mnaamani mnaamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worked really nicely. I left a small request which can be done in a separate PR.
There is now some common code across the pulumi projects, I can identify the Caddy service deployment for example. We should try to factor that out if possible.

...subkeyContainers,
{
name: 'builder-node',
image: 'joystream/node:latest',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is being pulled from docker hub if not found will pulumi try to build the image?
Can we make the image a configuration parameter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the image is pulled from docker hub. I'll make the image a configuration parameter.

@mnaamani mnaamani merged commit b43d9e1 into Joystream:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants