Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Olympia mappings - runtime forum/proposals changes adjustments, support for forum tags and proposals discussion #2547

Merged

Conversation

Lezek123
Copy link
Contributor

@Lezek123 Lezek123 commented Jul 26, 2021

Includes merged and updated work from #2436 (proposals discussion mappings) and adjustments related to changes introduced in:

Notable changes:

  • Forum tags are now supported as desribed in Olympia: Support for forum thread labels/tags #2422. create_thread extrinsic and edit_thread_metadata (previously edit_thread_title) now take encoded ForumMetadata as argument. The ThreadTitleUpdatedEvent entity has been renamed to ThreadMetadataUpdatedEvent
  • ForumTag.visibleThreadsCount and ForumThread.visiblePostsCount fields have been added, which will faciliate querying forum threads / tags by popularity (required by Pioneer 2). visible means that the posts/threads beeing counted are either Active or Locked, so this excludes posts/thread that are (or in case of post - are part of a thread that is) Moderated or Removed.
  • Initial post in the thread will now have a valid ID
  • The input format for polls in create_thread has been changed to take the actual input data instead of hashes.
  • delete_posts extrinsic signature has been changed. The extrinsic now takes BTreeMap as argument, which may require updating to @polkadot/api 5.2.1 (see: BTreeSet and BTreeMap - encoding and serialization fixes polkadot-js/api#3789) (this update was already done on this branch)

@Lezek123 Lezek123 marked this pull request as draft July 26, 2021 10:32
@jodator jodator mentioned this pull request Aug 5, 2021
6 tasks
@Lezek123 Lezek123 changed the title Olympia mappings - runtime forum/proposals changes adjustments, support for forum tags Olympia mappings - runtime forum/proposals changes adjustments, support for forum tags and proposals discussion Sep 3, 2021
@jodator jodator mentioned this pull request Sep 7, 2021
3 tasks
@jodator
Copy link
Contributor

jodator commented Sep 9, 2021

@Lezek123 & @mnaamani It looks that most of the queries now work with Olympia testnet 🎉

We do have however two minor issues regarding querying Hydra:

  1. Apply role filters for member search pioneer#857 (comment)
  2. Active posts queries do not work with Olympia testnet pioneer#1431

Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in the comment above ☝️ Most of the things in the Pioneer app works properly with the Olympia testnet.

@ondratra
Copy link
Contributor

We do have however two minor issues regarding querying Hydra:

  1. Apply role filters for member search pioneer#857 (comment)

This issue is being solved in Hydra PR Joystream/hydra#453 and tracked in ticket Joystream/hydra#444 . So I think we can merge this PR and solve the said problem separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants