Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevOps - Update Colossus deployment for Giza #2829

Merged
merged 4 commits into from
Dec 30, 2021

Conversation

ahhda
Copy link
Contributor

@ahhda ahhda commented Nov 12, 2021

  • Remove docker build within deployment
  • Add additional parameters like queryNodeHost, workerId, accountURI, colossusImage
  • Refactor generic configMap to pulumi-common
Manual testing
  • Running stack with these configurations
    Screenshot 2021-12-23 at 6 26 43 PM

  • The node runs without any issues
    Screenshot 2021-12-23 at 6 26 38 PM

Copy link
Member

@mnaamani mnaamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployment works well. Handling of keyFile/passphrase and accountUri configs needs improvement.

},
})
const remoteKeyFilePath = '/joystream/key-file.json'
additionalParams = ['--key-file', remoteKeyFilePath]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keyfile is required above but additionalParams are not used, since we are passing ACCOUNT_URI.

So we need better handling I think here of keyFile, passphrase, and accountUri configs, especially if both are set, which one takes precedence (based on storage-node implementation of course)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So according to the method getAccount in storage-node-v2/src/command-base/ApiCommandBase.ts if accountURI is specified it takes precedence and overrides password and keyFile flags.

Also either Keyfile or accountURI must be set otherwise we throw an error.

Will update this in the code.

@ahhda ahhda requested a review from mnaamani December 24, 2021 08:42
Copy link
Member

@mnaamani mnaamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue with the port configuration otherwise looks good.

'server',
'--worker',
workerId,
'--port=3333',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be the the pulumi configuration parameter 'colossusPort' instead of hard-coded 3333?

value: `${colossusPort}`,
},
{
name: 'QUERY_NODE_HOST',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has now changed to QUERY_NODE_ENDPOINT and is a full Url not just the host-name

@ahhda ahhda requested a review from mnaamani December 29, 2021 12:09
@mnaamani mnaamani merged commit 91ec5ac into Joystream:giza_staging Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants