Improved role staking #42
Conversation
| // send reward to member account - not the actor account | ||
| if let Ok(member_account) = T::Members::lookup_account_by_member_id(actor.member_id) { | ||
| let _ = T::Currency::deposit_into_existing(&member_account, params.reward); | ||
| // reward can top up balance if it is below minimum stake requirement |
There was a problem hiding this comment.
This looks like the right change, but for two comments:
- The reward must still exceed the balance used up during the lifetime of a block for anything to ever be paid out to the member and to guarantee that the actor can continue acting. I'm not sure this is enough, therefore.
- The effect of this is that busy actors actually produce less reward for their member than idle actors. I think that's the opposite of what's intended.
Maybe it's enough for getting Athens up and running, because the storage provider incentives are really only properly to be added in future. But it really doesn't seem entirely complete at this point.
There was a problem hiding this comment.
As we discussed IRL, these edge cases are correct, but would have to be solved by the working group in selecting the best set of role parameters to ensure storage providers are earning more than than their tx fees, as well as introducing a reward model that takes into account how busy the actors are.
There was a problem hiding this comment.
My main concern for Athens is really that storage providers don't run out of balance for transaction fees - I guess it's okay for now to require people to pay attention.
|
Ok, after the discussion, I think it's ok to move forward. I'd change the flags setting code just to be a bit safer, but otherwise let's merge this PR :) |
|
Updated flag setting code and tested locally works as expected. This is good to merge |
* Be explicit in supported input types * label as React$Node
Here is my proposal for improving the staking mechanism for the Actors/Roles.
Locked amount. We were locking the entire balance in the actor account.
The amount locked is now only the minimum stake required to enter role. Unlike the validators set, currently there is no elaborate selection algorithm for who makes it into the set of actors for a specific role, only criteria is staking minimum amount and there being an empty slot. (In future a dedicated working group will have responsibility of managing this set) So there is no need to lock the entire account balance, or even an advantage for a member to add more than minimum stake to their actor account.
Actor account can still withdraw for following reasons:
TransactionPayment, andFee. This allows for covering transaction fees for any extrinsic sent by actor account. The account cannot transfer balance or reserve while it is active in its role or unbonding.Rewards are paid out to actor account if its balance falls below the minimum stake requirement. (This will happen for two reasons, spending on tx fees and if the minimum stake is increased). Otherwise it goes to the member account.