Carthage: Staging parameters #4364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Lezek123
approved these changes
Oct 12, 2022
runtime/src/constants.rs
Outdated
| @@ -183,7 +183,7 @@ mod tests { | |||
| } | |||
|
|
|||
| // This test does not make sense for `testing_runtime`, because of 1s blocks | |||
There was a problem hiding this comment.
Suggested change
| // This test does not make sense for `testing_runtime`, because of 1s blocks | |
| // This test does not make sense for `testing-runtime`, because of 1s blocks |
runtime/src/constants.rs
Outdated
| @@ -211,7 +211,7 @@ mod tests { | |||
| } | |||
|
|
|||
| // This test does not make sense for `testing_runtime`, because of 1s blocks | |||
There was a problem hiding this comment.
Suggested change
| // This test does not make sense for `testing_runtime`, because of 1s blocks | |
| // This test does not make sense for `testing-runtime`, because of 1s blocks |
| @@ -0,0 +1,332 @@ | |||
| //! This module contains staging parameters for the runtime codex proposals. | |||
There was a problem hiding this comment.
Suggested change
| //! This module contains staging parameters for the runtime codex proposals. | |
| //! This module contains playground parameters for the runtime codex proposals. |
| @@ -1,72 +1,84 @@ | |||
| //! This module contains staging parameters for the runtime codex proposals. | |||
| //! This module contains default "production" parameters configuration for the runtime codex proposals. | |||
There was a problem hiding this comment.
Suggested change
| //! This module contains default "production" parameters configuration for the runtime codex proposals. | |
| //! This module contains staging parameters for the runtime codex proposals. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated runtime parameters as per #4355 to have a more easily testable staging network with similar constraints to production.
Updated feature names to match rust convention (removed underscore so
testing_runtime->testing-runtime)┆Issue is synchronized with this Asana task by Unito