Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docker image publish and runtime upgrade test workflow #4744

Merged
merged 12 commits into from
May 3, 2023

Conversation

mnaamani
Copy link
Member

@mnaamani mnaamani commented Apr 24, 2023

@vercel
Copy link

vercel bot commented Apr 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
pioneer-testnet ⬜️ Ignored (Inspect) Apr 26, 2023 7:04am

@mnaamani mnaamani force-pushed the joystream-node-docker-release branch from bdb0b86 to 90cbc19 Compare April 24, 2023 11:05
@mnaamani mnaamani force-pushed the joystream-node-docker-release branch from 8a3fef7 to a317f72 Compare April 24, 2023 15:33
@mnaamani mnaamani mentioned this pull request Apr 24, 2023
@mnaamani mnaamani changed the title Factor out publish of joystream/node:latest workflow Improve docker image publish and runtime upgrade test workflow Apr 24, 2023
Copy link
Contributor

@ignazio-bovo ignazio-bovo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have just left a small question

env:
RUNTIME: mainnetDev
TARGET_RUNTIME: latest
TARGET_RUNTIME: ${{ needs.build_images.outputs.runtime }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, this clearly needed to be adjusted

@@ -65,7 +66,7 @@ jobs:
- name: Cache docker images
uses: actions/cache@v3
env:
cache-name: joystream-node-docker
cache-name: joystream-node-docker-1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why there's a need for the -1 prefix?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I just wanted to force github to use a new cache and not rely on previously cached artifacts

@mnaamani mnaamani merged commit 399351a into Joystream:master May 3, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

joystream-node docker build failing with recent cargo-chef
2 participants