[Argus] add auth options to elastic logs config #4752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
kdembler
commented
May 9, 2023
Lezek123
suggested changes
May 10, 2023
There was a problem hiding this comment.
Thank you very much for this PR.
I tested the authentication and it works as expected.
I suggested some changes to the hideConfigPath functionality and mentioned in the reply above (kdembler#1)
Since it's going to be a new release, there are also few additional changes needed:
- Please bump the version in
distributor-node/package.jsonto1.2.0 - Please add new entry in
distributor-node/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow adding authentication options to Elasticsearch logging so that secured clusters can be used as well.