Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origo: fix unhandled QN exception in Argus #4769

Merged

Conversation

zeeshanakram3
Copy link
Contributor

Addresses #4762

How to test ?

Start the distributor-node, after node has been initialised & is up and running, stop the QN(graphql-server container). Now there shouldn't be any unhandled promise rejection warning, but an error log with the exception info.

(node:3358105) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection

@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
pioneer-testnet ⬜️ Ignored (Inspect) May 22, 2023 7:42pm

@zeeshanakram3 zeeshanakram3 added the argus Argus distributor node label May 23, 2023
@zeeshanakram3 zeeshanakram3 changed the title Origo: fix unhandled QN exception Origo: fix unhandled QN exception in Argus May 23, 2023
@mnaamani mnaamani merged commit 86a278a into Joystream:master Jun 12, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argus Argus distributor node
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants