Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme update links to binaries #4806

Merged
merged 6 commits into from
Jul 26, 2023

Conversation

mnaamani
Copy link
Contributor

@mnaamani mnaamani commented Jul 20, 2023

Update Readme to not reference testnet and make binaries and chainspec easier to find on landing readme page.

Also updated shasum calculation for runtime code to exclude .md so in future node rebuild isn't required if we simply change some docs, as it doesn't affect the compile process.

Some github actions are failing because the github runner is running out of space, a fix is available in this PR #4804 so maybe we can merge that first

@vercel
Copy link

vercel bot commented Jul 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
pioneer-testnet ⬜️ Ignored (Inspect) Jul 20, 2023 7:09pm

@mnaamani mnaamani requested review from bwhm and removed request for zeeshanakram3 July 26, 2023 13:55
@@ -14,6 +14,7 @@ fi

# sort/owner/group/mtime arguments only work with gnu version of tar!
${TAR} -c --sort=name --owner=root:0 --group=root:0 --mode 644 --mtime='UTC 2020-01-01' \
--exclude='*.md' \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this hash actually referred to anywhere?

@@ -49,7 +49,7 @@ yarn ts-node src/test-command.ts

Some examples of how to write "scripts" is available under [./scripts/](./scripts) folder.
These are "code-snippets" designed primarly for doing queries or very simple transactions.
If you follow the example format you can also copy/paste them into https://testnet.joystream.org/#/js for execution.
If you follow the example format you can also copy/paste them into https://polkadot.js.org/apps/#/js for execution.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these works...

Copy link
Member

@bwhm bwhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misclicked twice on "Add single comment", but these are super nitpicky :)

  • All links seem to work
  • All changes are to the better

The only testnet reference I found to be still around was in /runtime/README.md, and probably makes sense to keep for a while.

@mnaamani mnaamani merged commit 999090e into Joystream:master Jul 26, 2023
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants