Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nara] Remove channel and video deletion by moderators mappings and CLI commands #4875

Merged
merged 13 commits into from
Sep 28, 2023
Merged

[Nara] Remove channel and video deletion by moderators mappings and CLI commands #4875

merged 13 commits into from
Sep 28, 2023

Conversation

zeeshanakram3
Copy link
Contributor

@zeeshanakram3 zeeshanakram3 commented Sep 18, 2023 •
edited by sync-by-unito bot

This PR addresses:

┆Issue is synchronized with this Asana task by Unito

@bedeho bedeho added CLI Command Line Interface Tool query-node labels Sep 18, 2023
mnaamani
mnaamani requested changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@mnaamani mnaamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should drop the mappings from the query-node because we need it to handle those events from previous runtimes, when we are processing blocks from genesis.

I left a comment about this in #4874
Of course I also tried to fix the integration tests in that same PR and couldn't figure out why they were failing

https://github.com/Joystream/joystream/actions/runs/6218658040/job/16875580326?pr=4874#step:11:2141

Clearly you resolved it here :)

@mnaamani
Copy link
Contributor

Also this needs to be rebased onto nara branch

@mnaamani mnaamani mentioned this pull request Sep 20, 2023
Merged
7 tasks
@zeeshanakram3 zeeshanakram3 changed the base branch from master to nara September 25, 2023 04:37
@zeeshanakram3
Copy link
Contributor Author

I have:

  • Rebased the PR on nara branch
  • removed the deleted events (VideoDeletedByModerator & ChannelDeletedByModerator) events from runtime
  • Updated the chain metadata (there is a new metadata file query-node/chain-metadata/2002.json)
  • Reverted the mappings deletion change.
  • Updated the @joystream/types package based on new chain-metadata.
  • I have added a temporary tar dependency of the hydra-typegen fix to test the PR easily

@ignazio-bovo ignazio-bovo mentioned this pull request Sep 25, 2023
Merged
mnaamani
mnaamani requested changes Sep 26, 2023
View reviewed changes
query-node/codegen/package.json Outdated
@@ -11,6 +11,6 @@
},
"dependencies": {
"@joystream/hydra-cli": "5.0.0-alpha.4",
"@joystream/hydra-typegen": "5.0.0-alpha.4"
"@joystream/hydra-typegen": "file:../../joystream-hydra-typegen-v5.0.0-alpha.4.tgz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to use the newly published 5.0.0-alpha.6

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sorry, figured out that I didn't save the file before adding the commit

@mnaamani mnaamani self-requested a review September 26, 2023 14:29
@mnaamani
Copy link
Contributor

Merged this work in #4874

@mnaamani mnaamani merged commit 98990eb into Joystream:nara Sep 28, 2023
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnaamani mnaamani mnaamani approved these changes

Assignees

@mnaamani mnaamani

Labels
CLI Command Line Interface Tool query-node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zeeshanakram3 @mnaamani @bedeho @kdembler