Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nara] Increase workers runtime limit #4882

Merged
merged 1 commit into from
Sep 23, 2023
Merged

[Nara] Increase workers runtime limit #4882

merged 1 commit into from
Sep 23, 2023

Conversation

freakstatic
Copy link
Contributor

@freakstatic freakstatic commented Sep 21, 2023 •
edited
Loading

Implements #4822

@mnaamani mnaamani self-requested a review September 22, 2023 03:44
mnaamani
mnaamani approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@mnaamani mnaamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably do some tests with payouts when the max number of workers is hired. However I think we should be fine since payouts to different groups is spaced out by 10 blocks.

@mnaamani mnaamani merged commit 0bd2879 into Joystream:nara Sep 23, 2023
23 checks passed
@mochet
Copy link

mochet commented Sep 25, 2023

We should probably do some tests with payouts when the max number of workers is hired. However I think we should be fine since payouts to different groups is spaced out by 10 blocks.

Over a long enough time period wouldn't there be times when two or more working group payment periods line up and occur on the same block?

@freakstatic freakstatic mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnaamani mnaamani mnaamani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@freakstatic @mochet @mnaamani