Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nara] add new workers limits #4888

Merged
merged 1 commit into from
Sep 26, 2023
Merged

[Nara] add new workers limits #4888

merged 1 commit into from
Sep 26, 2023

Conversation

freakstatic
Copy link
Contributor

Implements #4822

@freakstatic
Copy link
Contributor Author

@mnaamani please review

@mnaamani mnaamani self-requested a review September 26, 2023 14:13
mnaamani
mnaamani approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@mnaamani mnaamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

Just a note, the benchmarks for on_initialize use the membership working group max worker limit to do the analysis, but should still be accurate enough for the larger groups.

@mnaamani mnaamani merged commit b9ac18a into Joystream:nara Sep 26, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnaamani mnaamani mnaamani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@freakstatic @mnaamani