Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[argus] few tweaks #4925

Merged
merged 4 commits into from
Oct 16, 2023
Merged

[argus] few tweaks #4925

merged 4 commits into from
Oct 16, 2023

Conversation

kdembler
Copy link
Member

  • Add 1s delay between fetching pages for QN state sync. This will allow QN to have some breathing space and process other requests that may have been stuck because of heavy processing.
  • Add Access-Control-Expose-Headers response header to allow web clients checking cache status of downloaded file.
  • Include response headers in http logs

Copy link
Contributor

@zeeshanakram3 zeeshanakram3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnaamani
Copy link
Contributor

mnaamani commented Oct 16, 2023

The browser is getting the header Access-Control-Expose-Headers twice for each value:

Screenshot 2023-10-16 at 10 39 26 AM

I would have expected one header with the multiple values. Is this the expected response?

In the past I have observed firefox at least complain about saying a header multiple times.. with CORS headers for example. But it doesn't seem to be an issue with this header.

Copy link
Contributor

@mnaamani mnaamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor merge conflict fix needed otherwise I think this is good to go.

@kdembler
Copy link
Member Author

Good call @mnaamani, changed to a single header with comma-separated values. Also rebased and fixed conflicts

@mnaamani mnaamani self-requested a review October 16, 2023 13:38
@mnaamani mnaamani merged commit 8d3d5b4 into Joystream:master Oct 16, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants