QueryNode, metadata-protobuf and joystream/js package releases #4943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The distributor-node/package.json & storage-node/package.json still have metadata-protobuf dependency with the previous version. Shouldn't we update the dependency at all places?
It was not strictly necessary for storage and distributor nodes because they do not actually use any of the new changes in the metadata-protobuf package, that is why I didn't update them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #4927 preparing releases for affected packages.
Note bump to metadata-protobuf skipping v2.9.0 which was published from crt-release branch that included Token.proto which is being ported into this release on master branch.