FIX gracefully handle logging exceptions in Argus and Colossus #4963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdembler
reviewed
Nov 10, 2023
kdembler
reviewed
Nov 10, 2023
| @@ -50,7 +50,7 @@ | |||
| "url-join": "^4.0.1", | |||
| "winston": "^3.3.3", | |||
There was a problem hiding this comment.
Should we maybe bump winston as well while we're at it?
There was a problem hiding this comment.
Ok. I tried to update the winston to the most recent version and it turned out that it contains breaking changes (so will have to update code at couple of places). So unless we absolutely want to update the dependency, I would say it's fine for now. WDYT?
There was a problem hiding this comment.
yes, let's ignore in that case
kdembler
approved these changes
Nov 10, 2023
mnaamani
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As reported by @kdembler the Distributor node crashed with restarting the ES node, or if providing the wrong credentials. This happened because the code was not gracefully the exceptions
Fix
This PR gracefully handles logging exceptions in Argus and Colossus