Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test script runners refactoring #4970

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

mnaamani
Copy link
Contributor

@mnaamani mnaamani commented Nov 21, 2023

Problem: Too many confusing variables, and scripts to run integration tests.

Solution:

  • A bit of house keeping.
  • Dropped the REUSE_KEYS environment variable. When a scenario is run and output.json is found, the generated keys will be loaded from it.
  • Updated scripts to explicitly remove output.json where appropriate. eg. when scenario is run to initialize a new network.
  • Adding a new scenario called flow which can be used to run an individual flow. This allows us to more flexibly run flows without need to group them in a scenario.
  • Changed default behavior of yarn test and yarn start to start a test chain (TESTING runtime profile)

Copy link
Contributor

@zeeshanakram3 zeeshanakram3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few comments:

  • In the Github workflows we still use yarn build:packages, maybe better to replace with yarn build for consistency?
  • We should also remove run-test-node-docker.sh script too, it only exporting RUNTIME_PROFILE=TESTING , maybe do that in the calling script?

Copy link
Contributor

@zeeshanakram3 zeeshanakram3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnaamani mnaamani merged commit 83e80da into Joystream:master Nov 29, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants