[Colossus] Sync rework - #5014
Merged
[Colossus] Sync rework - #5014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnaamani
requested changes
Dec 28, 2023
| // Create an array of operator URL indices to maintain a random URL choice | ||
| // cannot use the original array because we shouldn't modify the original data. | ||
| // And cloning it seems like a heavy operation. | ||
| const operatorUrlIndices: number[] = [...Array(this.operatorUrls.length).keys()] |
There was a problem hiding this comment.
I can suggest a slightly cleaner approach. Start with an array already containing random order of the indices using a combination of _.range() and _.shuffle(). You could then just shift or pop the array at the start of the loop. Or the while loop then can be a simply a for..each iteration over the array, without needing to modify it.
const operatorUrlIndices: number[] = _.shuffle(_.range(this.operatorUrls.length))
mnaamani
reviewed
Dec 28, 2023
| logger.debug(`Sync - random storage node URL was chosen ${chosenBaseUrl}`) | ||
|
|
||
| // Remove random url from the original list. | ||
| _.remove(operatorUrlIndices, (index) => index === randomUrlIndex) |
There was a problem hiding this comment.
removing the element is no longer necessary, even potentially problematic.
There was a problem hiding this comment.
Ah right. Missed that.
There was a problem hiding this comment.
Addressed in 3c02240
mnaamani
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
colses #5008
This PR:
apiparameter from theperformSyncfunction & fetch the object hash from QN instead of fetching from the runtime.superagenterror handler - when the object does not exist in the remote node - won't be logged, since technically missing asset won't be categorized as an error, and logging this as an error may confuse the Operator/Lead