Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tooltip text Proposals>Preview>Discussion Open #3900

Closed
polikosi opened this issue Nov 28, 2022 · 5 comments
Closed

Update tooltip text Proposals>Preview>Discussion Open #3900

polikosi opened this issue Nov 28, 2022 · 5 comments
Labels
bug Something isn't working community-dev issue suitable for community-dev pipeline good first issue These issues are a great way to get started with a Pioneer qa-task qa-tested-ready-for-prod release:1.3.2 SP:1
Projects
Pioneer Community Product Development

Comments

@polikosi
Copy link

Update tooltip text. Remove "Dolore magna anim eu nisi qui."
image
@polikosi polikosi added the bug Something isn't working label Nov 28, 2022
@traumschule traumschule added good first issue These issues are a great way to get started with a Pioneer community-dev issue suitable for community-dev pipeline labels Nov 28, 2022
@traumschule
Copy link
Contributor

traumschule commented Nov 28, 2022 •
edited

@dmtrjsg is there something smart to tell about the discussion mode? There might be even a related PR, let me check. No doesn't look like.

@dmtrjsg
Copy link
Contributor

dmtrjsg commented Dec 2, 2022 •
edited

@traumschule how about "Open discussion is open for every member to comment on, while closed would only be available for council members, white-listed members and creator of the proposal."

@dmtrjsg dmtrjsg added this to Community Dev Backlog in Pioneer Community Product Development Dec 2, 2022
traumschule pushed a commit to traumschule/pioneer that referenced this issue Dec 11, 2022
Proposal discussion mode tooltip text (Joystream#3900)
2ae6a8d
@traumschule traumschule mentioned this issue Dec 11, 2022
Open
@chrlschwb chrlschwb moved this from Community Dev Backlog to Ready to Test in Pioneer Community Product Development Jan 26, 2023
@polikosi
Copy link
Author

tested on: https://dao-git-dev-joystream.vercel.app/#/forum/thread/7
wss://34.230.5.182.nip.io/ws-rpc

image

@traumschule @dmtrjsg
Hi, what text did you choose as the final result?
1. "Open discussion is open for every member to comment on, while closed would only be available for council members, white-listed members and creator of the proposal"
2. "This is an unmoderated discussioon, everyone can comment."
3. "This is an open discussion, everyone can comment."

@traumschule
Copy link
Contributor

traumschule commented Jan 28, 2023 •
edited

Updated PR to go with 1: 4802472

@polikosi
Copy link
Author

tested on: https://pioneer-2-p25kt19dq-joystream.vercel.app/#/settings?network-config=https://34.230.5.182.nip.io/network/config.json
image

@chrlschwb chrlschwb moved this from Ready to Test to Tested - Ready for Prod in Pioneer Community Product Development Jan 31, 2023
@chrlschwb chrlschwb moved this from Tested - Ready for Prod to Dev In progress in Pioneer Community Product Development Mar 22, 2023
@chrlschwb chrlschwb mentioned this issue Mar 23, 2023
Merged
thesan pushed a commit that referenced this issue Mar 30, 2023
@chrlschwb
Fix Proposal Preview Tooltip (#3900) (#4257)
91a0323 
fix change hit of proposals preview
@chrlschwb chrlschwb moved this from Dev In progress to Tested - Ready for Prod in Pioneer Community Product Development Mar 30, 2023
Pioneer Community Product Development automation moved this from Tested - Ready for Prod to Closed - On Prod Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working community-dev issue suitable for community-dev pipeline good first issue These issues are a great way to get started with a Pioneer qa-task qa-tested-ready-for-prod release:1.3.2 SP:1
Projects
Pioneer Community Product Development
Closed - On Prod
Milestone
No milestone
Development

No branches or pull requests
5 participants
@thesan @traumschule @polikosi @dmtrjsg @chrlschwb