Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[USERSNAP] can't create proposals #3909

Open
1 task
dmtrjsg opened this issue Nov 30, 2022 · 8 comments
Open
1 task

[USERSNAP] can't create proposals #3909

dmtrjsg opened this issue Nov 30, 2022 · 8 comments
Labels
bug Something isn't working community-dev issue suitable for community-dev pipeline qa-task SP:2

Comments

@dmtrjsg
Copy link
Contributor

dmtrjsg commented Nov 30, 2022

Scope

  • Add a warning message somewhere that the number of active proposals are restricted to 20 based on the current runtime configuration. Maybe unblock the button and when clicked show it in the modal?

More info is here>

## Context

Taken at: https://dao.joystream.org/#/proposals/current
Fields:

  • Houston, we have a problem.: can't create proposals
  • Comment: can't create proposals is we have many proposals approved and in the gracing period

SCREENSHOT
Download original image

Browser: Chrome 107 (macOS Catalina)
Screen size: 1920x1080
Browser size: 1720x761
Open #348 in Usersnap

Powered by Usersnap.

@dmtrjsg dmtrjsg added the bug Something isn't working label Nov 30, 2022
@dmtrjsg dmtrjsg self-assigned this Nov 30, 2022
@dmtrjsg
Copy link
Contributor Author

dmtrjsg commented Dec 2, 2022

@Lezek123 could you advise here pls on how the limitations are set up rn on the concurrent number of active proposals? (Suspect the limit covers both gracing and open)

Screenshot 2022-12-02 at 19 52 19

@Lezek123
Copy link

Lezek123 commented Dec 2, 2022

@dmtrjsg The limit is 20 active proposals: https://github.com/Joystream/joystream/blob/master/runtime/src/lib.rs#L1571. Active refers to proposals that haven't reached their final status yet. The number of active proposals can be either retrieved from the query node:

query {
  proposalsConnection(where: { isFinalized_eq: false }) {
    totalCount
  }
}

Or from chain via api.query.proposalsEngine.activeProposalCount

@dmtrjsg dmtrjsg added design Description of a feature scope or detailed requirements and removed feedback-follow-up labels Dec 2, 2022
@dmtrjsg dmtrjsg removed their assignment Dec 2, 2022
@dmtrjsg
Copy link
Contributor Author

dmtrjsg commented Dec 2, 2022

over to you sir @ninja-fire

@ninja-fire
Copy link

ninja-fire commented Dec 2, 2022

image

for now, I would suggest an easy way to find a solution to this issue like is the image above:

  • disable the button "create new proposal"
  • add an error message explaining the restrictions

@traumschule
Copy link
Contributor

Had the idea for a tooltip instead: #3916. WDYT?

add-proposal-tooltip

@traumschule traumschule added the community-dev issue suitable for community-dev pipeline label Dec 2, 2022
@ninja-fire
Copy link

Had the idea for a tooltip instead: #3916. WDYT?

add-proposal-tooltip

I really like your proposition, it makes sense. The user that wants to add a proposal will be aware of the limit, otherwise, he doesn't care so he doesn't need to go. nice!

@traumschule traumschule added qa-task and removed design Description of a feature scope or detailed requirements labels Dec 6, 2022
@dmtrjsg dmtrjsg assigned ninja-fire and unassigned dmtrjsg Dec 8, 2022
@dmtrjsg dmtrjsg added the design Description of a feature scope or detailed requirements label Dec 9, 2022
@chrlschwb
Copy link
Contributor

Looks like this issue is solved and ready for review.

@chrlschwb chrlschwb removed the design Description of a feature scope or detailed requirements label Jan 28, 2023
@chrlschwb chrlschwb assigned traumschule and unassigned ninja-fire Jan 28, 2023
@chrlschwb chrlschwb moved this from To-Triage to Ready to Test in Pioneer Community Product Development Jan 28, 2023
@traumschule traumschule removed their assignment Jan 28, 2023
@polikosi
Copy link

polikosi commented Feb 1, 2023

@chrlschwb chrlschwb moved this from Ready to Test to Tested - Ready for Prod in Pioneer Community Product Development Feb 2, 2023
@chrlschwb chrlschwb moved this from Tested - Ready for Prod to In Review in Pioneer Community Product Development Mar 22, 2023
@chrlschwb chrlschwb moved this from In Review to Community Dev Backlog in Pioneer Community Product Development Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community-dev issue suitable for community-dev pipeline qa-task SP:2
Projects
Development

No branches or pull requests

6 participants