Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font text too small? #4094

Closed
bedeho opened this issue Jan 16, 2023 · 11 comments
Closed

Font text too small? #4094

bedeho opened this issue Jan 16, 2023 · 11 comments
Labels
community-dev issue suitable for community-dev pipeline enhancement New feature or request high-prio qa-tested-ready-for-prod release:1.5.0 scope:forum The "Forum" page and related features SP:2

Comments

@bedeho
Copy link
Member

bedeho commented Jan 16, 2023

Perhaps I'm just getting old, but isn't the font text just needlessly small, despite being the main thing you want to process? Compare this
Screenshot 2023-01-16 at 18 23 49

to this

Screenshot 2023-01-16 at 18 24 41

isn't the latter way way easier to read, but also looks fine?

@bedeho bedeho added the enhancement New feature or request label Jan 16, 2023
@traumschule
Copy link
Contributor

A smart way UI to increase font size would be great (without having to resort to page zoom). Also the font isn't a most readable one.

@traumschule traumschule added design Description of a feature scope or detailed requirements SP:2 labels Jan 17, 2023
@traumschule
Copy link
Contributor

When writing forum posts I started to increase font size to 20px via right-click 'inspect' on a line in the editor.
@bedeho try if that would be pleasant for you

font-size

@bedeho
Copy link
Member Author

bedeho commented Jan 27, 2023

Yeah, the fact that you were doing that is a pretty solid sign we should increase this 🤣

@dmtrjsg dmtrjsg added community-dev issue suitable for community-dev pipeline scope:forum The "Forum" page and related features labels Jan 27, 2023
@dmtrjsg dmtrjsg removed the design Description of a feature scope or detailed requirements label Jan 30, 2023
@chrlschwb chrlschwb moved this from To-Triage to Community Dev Backlog in Pioneer Community Product Development Feb 2, 2023
@chrlschwb chrlschwb moved this from Community Dev Backlog to Up-Next in Pioneer Community Product Development Mar 22, 2023
@thesan
Copy link
Member

thesan commented Mar 30, 2023

@bedeho @dmtrjsg @traumschule sorry I'm late on this but I'm not convinced increasing the font size is the right move.

It doesn't has to do with age as much as screen dpi getting denser with time, now there are even 4k laptop screens 😮 .

However most websites don't increase there font sizes in reaction, e.g github, reddit, twitter all keep their text smaller than 16px (which is Pioneer's current default font size).

Instead Chrome matches the user's systems font scaling factor. I mainly use FF (mostly at 110% zoom but that's easy to adapt depending on the page) but when I open e.g: https://dao-git-fork-chrlschwb-fix-4094-fonttextsmall-joystream.vercel.app/#/forum/thread/324 on Chrome due to my system 120% font scaling factor I get 20px * 1.2 which looks bad IMO. I think this problem would affect most Chrome users and this is why most websites keep the same font sizes.

WDYT ?

@chrlschwb
Copy link
Contributor

I think we should just add a font size controller. zoom in and zoom out...
#4308

@dmtrjsg
Copy link
Contributor

dmtrjsg commented Mar 31, 2023

@chrlschwb If that's available in both system and browser settings, why would we bloat the scope of Pioneer to replicate exactly same feature? I think based on that and benchmarking with popular websites we should close 4308..

@thesan
Copy link
Member

thesan commented Mar 31, 2023

Also the font isn't a most readable one.

@traumschule the font color might be more of an issue than the font itself.
It's a grey which isn't very dark for a light theme reading font:
image

In contrast with the GH font color of this message (if you are using the "light default" theme):
image

And it's not even the accessibility high contrast theme.

@traumschule
Copy link
Contributor

Good point. Not sure if that's too hacky but we could use onHover onActive to switch to a high-contrast, bigger size etc scheme on post hover?
Or regarding the looking glass option:

htmlElement.addEventListener('mousedown', focusPost)

@bedeho
Copy link
Member Author

bedeho commented Apr 1, 2023

sorry I'm late on this but I'm not convinced increasing the font size is the right move.

Yes you may very well be right that sizing is not the right fix, make the call.

I think we should just add a font size controller. zoom in and zoom out...

I don't think this is wise. Products should just work and have good readability, adding tons of controls that users have to understand and manage should be the last resort, and not really warranted here.

@chrlschwb
Copy link
Contributor

I will just try to change the font color then.

@chrlschwb chrlschwb moved this from Up-Next to Dev In progress in Pioneer Community Product Development Apr 10, 2023
thesan added a commit that referenced this issue Apr 24, 2023
* fix color

---------

Co-authored-by: Theophile Sandoz <theophile.sandoz@gmail.com>
@chrlschwb chrlschwb moved this from Dev In progress to Ready to Test in Pioneer Community Product Development Apr 26, 2023
@ivanturlakov
Copy link

✅ Tested on https://dao-git-dev-joystream.vercel.app/#/forum/thread/2
wss://54.205.24.16.nip.io/ws-rpc

Font color changed
Screenshot 2023-04-27 at 19 06 16
Screenshot 2023-04-27 at 19 02 15

@chrlschwb chrlschwb moved this from Ready to Test to Tested - Ready for Prod in Pioneer Community Product Development Apr 28, 2023
Pioneer Community Product Development automation moved this from Tested - Ready for Prod to Closed - On Prod Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-dev issue suitable for community-dev pipeline enhancement New feature or request high-prio qa-tested-ready-for-prod release:1.5.0 scope:forum The "Forum" page and related features SP:2
Projects
Development

No branches or pull requests

6 participants